Closed kaldebert closed 6 years ago
Merging #121 into master will increase coverage by
0.04%
. The diff coverage is100%
.
@@ Coverage Diff @@
## master #121 +/- ##
============================================
+ Coverage 79.75% 79.79% +0.04%
- Complexity 1652 1654 +2
============================================
Files 156 156
Lines 5536 5538 +2
Branches 710 711 +1
============================================
+ Hits 4415 4419 +4
+ Misses 843 842 -1
+ Partials 278 277 -1
Impacted Files | Coverage Δ | Complexity Δ | |
---|---|---|---|
...e/api/server/spi/discovery/DiscoveryGenerator.java | 87.68% <100%> (+0.12%) |
52 <0> (+1) |
:arrow_up: |
...i/config/annotationreader/ApiAnnotationConfig.java | 88.37% <0%> (+2.32%) |
49% <0%> (+1%) |
:arrow_up: |
Continue to review full report at Codecov.
Legend - Click here to learn more
Δ = absolute <relative> (impact)
,ø = not affected
,? = missing data
Powered by Codecov. Last update 37ea315...18dc950. Read the comment docs.
CLAs look good, thanks!
I signed it!
Hi @tangiel, is there anything else we should do to have this one merged? It's actually a regression from Cloud Endpoints v1, documentationLink used to be displayed. Thanks!
Nope, sorry for missing it. Thanks!
Thanks for your pull request. It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).
:memo: Please visit https://cla.developers.google.com/ to sign.
Once you've signed, please reply here (e.g.
I signed it!
) and we'll verify. Thanks.