search

cloudendpoints / endpoints-java

A Java framework for building RESTful APIs on Google App Engine
Apache License 2.0
32 stars 35 forks source link

Allow to set API icons in @Api + use new Google logo #122

Closed clementdenis closed 6 years ago

clementdenis commented 6 years ago

The new logo is coming from the default icon in the public API Explorer

codecov-io commented 6 years ago

Codecov Report

Merging #122 into master will decrease coverage by 0.14%. The diff coverage is 48%.

Impacted file tree graph

@@             Coverage Diff             @@
##             master    #122      +/-   ##
===========================================
- Coverage     79.75%   79.6%   -0.15%     
- Complexity     1652    1658       +6     
===========================================
  Files           156     156              
  Lines          5536    5561      +25     
  Branches        710     713       +3     
===========================================
+ Hits           4415    4427      +12     
- Misses          843     851       +8     
- Partials        278     283       +5
Impacted Files Coverage Δ Complexity Δ
...e/api/server/spi/discovery/DiscoveryGenerator.java 85.85% <0%> (-1.71%) 51 <0> (ø)
...server/spi/config/jsonwriter/JsonConfigWriter.java 66.55% <0%> (-1.11%) 48 <0> (ø)
...ig/annotationreader/ApiConfigAnnotationReader.java 94.53% <100%> (+0.06%) 48 <0> (ø) :arrow_down:
.../google/api/server/spi/config/model/ApiConfig.java 94.85% <100%> (+0.24%) 73 <4> (+4) :arrow_up:
...i/config/annotationreader/ApiAnnotationConfig.java 82.6% <33.33%> (-3.44%) 50 <2> (+2)

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 37ea315...8e89f44. Read the comment docs.

tangiel commented 6 years ago

Hey @clementdenis, thanks for the PR! Unfortunately, I have been told that the icon customization is on the deprecation path, so we shouldn't allow customization. But if you want to include the change to the new logo, I'm fine with it.

clementdenis commented 6 years ago

Hi @tangiel, I submitted a #131 with only the change to the default Google icon, you can close this one. It's a bit sad this feature is getting deprecated, for example we have about 20 APIs in a single App Engine project, having different icons in the API explorer would be really great.

tangiel commented 6 years ago

Thanks as always, Clement. I forwarded your feedback to the API Explorer team.