search

cloudendpoints / endpoints-java

A Java framework for building RESTful APIs on Google App Engine
Apache License 2.0
32 stars 35 forks source link

quietly allow underscores in API names #147

Closed tangiel closed 6 years ago

tangiel commented 6 years ago

The official documentation for a long time has disallowed underscores in API names, so I'm leaving it as such. However, for extremely old users of the old frameworks, this limitation was not in place. Therefore, I'm removing it from the API validation, but leaving the @Api documentation in order to not encourage the style.

codecov-io commented 6 years ago

Codecov Report

Merging #147 into master will not change coverage. The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master     #147   +/-   ##
=========================================
  Coverage     80.01%   80.01%           
  Complexity     1678     1678           
=========================================
  Files           156      156           
  Lines          5595     5595           
  Branches        730      730           
=========================================
  Hits           4477     4477           
  Misses          840      840           
  Partials        278      278
Impacted Files Coverage Δ Complexity Δ
...rver/spi/config/validation/ApiConfigValidator.java 76.57% <ø> (ø) 65 <0> (ø) :arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update d41d772...126a136. Read the comment docs.