search

cloudendpoints / endpoints-java

A Java framework for building RESTful APIs on Google App Engine
Apache License 2.0
32 stars 35 forks source link

check non-nullness of required parameters #148

Closed tangiel closed 6 years ago

tangiel commented 6 years ago

@Named parameters that don't have @Nullable parameters are deemed required. Endpoints v2 lost this request validation, but this change adds it back in. Previously, the framework would assume the validation was done.

codecov-io commented 6 years ago

Codecov Report

Merging #148 into master will increase coverage by 0.06%. The diff coverage is 66.66%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master     #148      +/-   ##
============================================
+ Coverage     80.01%   80.08%   +0.06%     
- Complexity     1678     1726      +48     
============================================
  Files           156      156              
  Lines          5595     5694      +99     
  Branches        730      766      +36     
============================================
+ Hits           4477     4560      +83     
- Misses          840      844       +4     
- Partials        278      290      +12
Impacted Files Coverage Δ Complexity Δ
.../server/spi/request/ServletRequestParamReader.java 83.59% <66.66%> (-0.41%) 28 <2> (+4)
...rver/spi/config/validation/ApiConfigValidator.java 79.33% <0%> (+2.76%) 109% <0%> (+44%) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update d41d772...aab3f07. Read the comment docs.