Closed eddiemay closed 1 year ago
Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).
:memo: Please visit https://cla.developers.google.com/ to sign.
Once you've signed (or fixed any issues), please reply here (e.g. I signed it!
) and we'll verify it.
Merging #164 into master will decrease coverage by
0.03%
. The diff coverage is76.47%
.
@@ Coverage Diff @@
## master #164 +/- ##
============================================
- Coverage 80.12% 80.08% -0.04%
- Complexity 1689 1690 +1
============================================
Files 157 157
Lines 5629 5638 +9
Branches 735 736 +1
============================================
+ Hits 4510 4515 +5
- Misses 838 842 +4
Partials 281 281
Impacted Files | Coverage Δ | Complexity Δ | |
---|---|---|---|
...rver/spi/response/ServletResponseResultWriter.java | 94.73% <100%> (ø) |
17 <2> (ø) |
:arrow_down: |
.../server/spi/request/ServletRequestParamReader.java | 83.59% <100%> (ø) |
28 <0> (ø) |
:arrow_down: |
.../google/api/server/spi/ConfiguredObjectMapper.java | 90% <100%> (+0.41%) |
4 <0> (ø) |
:arrow_down: |
...erver/spi/config/model/ApiSerializationConfig.java | 75% <42.85%> (-7.76%) |
10 <1> (+1) |
Continue to review full report at Codecov.
Legend - Click here to learn more
Δ = absolute <relative> (impact)
,ø = not affected
,? = missing data
Powered by Codecov. Last update 413e434...623b15c. Read the comment docs.
I signed it!
If the protobuf module version does not support 2.9, should we really be using it? Jackson 2.9 came out over a year ago, so this incompatibility signifies a lack of development activity.
Code cleanup of ServletResponseResultWriter