Fix JacksonResourceSchemaProvider to work with both the older and newer jackson versions.

cloudendpoints / endpoints-java

A Java framework for building RESTful APIs on Google App Engine

Apache License 2.0

32 stars 35 forks source link

Fix JacksonResourceSchemaProvider to work with both the older and newer jackson versions. #207

Open gauravkghildiyal opened 3 years ago

gauravkghildiyal commented 3 years ago

getGenericType() method has been deprecated and removed in the newer jackson2 version. This fix allows things to work with the newer jackson2 version as well.

cmaan commented 2 years ago

We hit this today when upgrading jackson, this MR fixed the problem

peterfortuin commented 2 years ago

I have this problem as well. @cmaan can you tell me how you have tested or integrated this pull request change into your project?

cmaan commented 2 years ago

@peterfortuin Hey! We've been using jitpack to build a custom version on top of 2.2.2 which integrates this MR (as well as #192, which you can probably ignore) and use that as dependency. See:

ATM, until this is merged, we're depending on these artefacts:

com.github.cmaan.endpoints-java:endpoints-framework:v2.2.2-fix-jackson
com.github.cmaan.endpoints-java:endpoints-framework-guice:v2.2.2-fix-jackson

william-ferguson-au commented 1 year ago

Are there any committers for this project that can merge this PR in and release a new version or are we on our own?