cloudendpoints / endpoints-java

A Java framework for building RESTful APIs on Google App Engine
Apache License 2.0
32 stars 35 forks source link

1.9.30 GAE dependency #51

Closed ludoch closed 7 years ago

ludoch commented 7 years ago

Not sure why we need this, but I see 1.9.30 in https://github.com/cloudendpoints/endpoints-java/blob/087db2f1714e9b2204f6c698d91f9145ef24bc90/gradle.properties and 1.9.30 popups as a dependency on this Maven plugin as well... Should we either cut the dep or move it to 1.9.49 and keep it up to date every time there is a release of the endpoints artifact?

ludoch commented 7 years ago

@loosebazooka FYI, might want to notify Patrick... Endpoints tooling should also not depend on appengine SDK (or why?)

loosebazooka commented 7 years ago

I think this is an issue for @tangiel ? Is the dependency necessary?

tangiel commented 7 years ago

We're working on making the SDK dependency optional in the core framework (mostly done). Our command line tool actually depends on the App Engine CLI classes, so we can't remove the dependency there yet.

ludoch commented 7 years ago

So we can at least use 1.9.49 and have some manual process to verify once in a while it is up to date.

On Fri, Feb 3, 2017 at 2:15 PM, Daniel T notifications@github.com wrote:

We're working on making the SDK dependency optional in the core framework (mostly done). Our command line tool actually depends on the App Engine CLI classes, so we can't remove the dependency there yet.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/cloudendpoints/endpoints-java/issues/51#issuecomment-277377216, or mute the thread https://github.com/notifications/unsubscribe-auth/AAE4zbywimGEuMqF5oGSOnXyg5Y7BgdQks5rY6bvgaJpZM4L22lX .

tangiel commented 7 years ago

Yep, I submitted a change to update to 1.9.49.