search

cloudendpoints / endpoints-java

A Java framework for building RESTful APIs on Google App Engine
Apache License 2.0
32 stars 35 forks source link

fix stack overflow issue with recursive schema #66

Closed tangiel closed 7 years ago

tangiel commented 7 years ago

Currently, if you add a self-referencing type to multiple APIs, a StackOverflowError will occur. This change fixes that by not attempting to add a type to an API that's already added.

codecov-io commented 7 years ago

Codecov Report

Merging #66 into master will decrease coverage by -0.05%. The diff coverage is 100%.

@@             Coverage Diff              @@
##             master      #66      +/-   ##
============================================
- Coverage     79.68%   79.63%   -0.05%     
+ Complexity     1622     1620       -2     
============================================
  Files           154      154              
  Lines          5438     5440       +2     
  Branches        700      700              
============================================
- Hits           4333     4332       -1     
- Misses          832      833       +1     
- Partials        273      275       +2
Impacted Files Coverage Δ Complexity Δ
.../api/server/spi/config/model/SchemaRepository.java 91.83% <100%> (-2.96%) 26 <3> (-2)

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 0cd4fe7...47e7fbf. Read the comment docs.