search

cloudendpoints / endpoints-java

A Java framework for building RESTful APIs on Google App Engine
Apache License 2.0
32 stars 35 forks source link

fix empty servicePath in discovery #76

Closed tangiel closed 7 years ago

tangiel commented 7 years ago

The discovery test was not catching this issue in part because it wasn't using the exact same JSON serialization as it does at runtime. That has also been fixed. This change will likely reintroduce empty maps in serialization, but this is currently the best workaround to allow empty strings inside maps, which we need to serialize the discovery document correctly.

codecov-io commented 7 years ago

Codecov Report

Merging #76 into master will decrease coverage by 0.12%. The diff coverage is 100%.

@@             Coverage Diff              @@
##             master      #76      +/-   ##
============================================
- Coverage     79.49%   79.36%   -0.13%     
+ Complexity     1619     1617       -2     
============================================
  Files           154      154              
  Lines          5447     5447              
  Branches        701      701              
============================================
- Hits           4330     4323       -7     
- Misses          840      849       +9     
+ Partials        277      275       -2
Impacted Files Coverage Δ Complexity Δ
...va/com/google/api/server/spi/ObjectMapperUtil.java 46.66% <100%> (-15.56%) 4 <0> (-2)

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update fa30223...3ceda5d. Read the comment docs.