cloudendpoints / endpoints-java

A Java framework for building RESTful APIs on Google App Engine
Apache License 2.0
32 stars 35 forks source link

use hostname and path flags in all of the CLI #83

Closed tangiel closed 7 years ago

tangiel commented 7 years ago

App Engine is deprecating app IDs in config and we want to get away from this model anyway. This change adds --hostname and --path to get-discovery-doc and get-client-lib to fully specify where an API is hosted. This involves the following code changes:

codecov-io commented 7 years ago

Codecov Report

Merging #83 into master will increase coverage by 0.04%. The diff coverage is 78.94%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master      #83      +/-   ##
============================================
+ Coverage      79.4%   79.45%   +0.04%     
- Complexity     1618     1619       +1     
============================================
  Files           154      154              
  Lines          5449     5457       +8     
  Branches        702      702              
============================================
+ Hits           4327     4336       +9     
+ Misses          848      846       -2     
- Partials        274      275       +1
Impacted Files Coverage Δ Complexity Δ
...ogle/api/server/spi/tools/EndpointsToolAction.java 86.39% <ø> (+0.68%) 44 <0> (+1) :arrow_up:
.../google/api/server/spi/config/model/ApiConfig.java 94.44% <ø> (ø) 67 <0> (ø) :arrow_down:
...oogle/api/server/spi/tools/GetClientLibAction.java 76.92% <100%> (+1.92%) 3 <0> (ø) :arrow_down:
...java/com/google/api/server/spi/ServiceContext.java 83.33% <75%> (-0.88%) 11 <7> (ø)
...le/api/server/spi/tools/GetDiscoveryDocAction.java 32.14% <80%> (+3.05%) 3 <0> (ø) :arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 83a9773...94876c8. Read the comment docs.