search

cloudendpoints / endpoints-management-java

A Java library for managing API services using Google's Service Control APIs
Apache License 2.0
8 stars 12 forks source link

quota aggregation #29

Closed tangiel closed 7 years ago

codecov-io commented 7 years ago

Codecov Report

Merging #29 into master will increase coverage by 0.05%. The diff coverage is 40.48%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master      #29      +/-   ##
============================================
+ Coverage     63.56%   63.62%   +0.05%     
  Complexity      616      616              
============================================
  Files            44       44              
  Lines          2989     2988       -1     
  Branches        450      449       -1     
============================================
+ Hits           1900     1901       +1     
+ Misses          932      931       -1     
+ Partials        157      156       -1
Impacted Files Coverage Δ Complexity Δ
...om/google/api/control/aggregator/MetricValues.java 90.62% <ø> (ø) 13 <0> (ø) :arrow_down:
...a/com/google/api/config/ServiceConfigSupplier.java 66.66% <ø> (ø) 12 <0> (ø) :arrow_down:
...a/com/google/api/control/model/QuotaErrorInfo.java 0% <0%> (ø) 0 <0> (ø) :arrow_down:
...va/com/google/api/control/model/OperationInfo.java 100% <100%> (ø) 24 <4> (ø) :arrow_down:
...pi/control/aggregator/QuotaAggregationOptions.java 100% <100%> (ø) 5 <5> (ø) :arrow_down:
...l/src/main/java/com/google/api/control/Client.java 45.31% <18.18%> (ø) 18 <1> (ø) :arrow_down:
...a/com/google/api/control/model/MethodRegistry.java 10.05% <33.33%> (ø) 0 <0> (ø) :arrow_down:
...com/google/api/control/model/QuotaRequestInfo.java 34.14% <34.14%> (ø) 4 <4> (ø) :arrow_down:
...i/control/aggregator/QuotaOperationAggregator.java 52.94% <52.94%> (ø) 7 <7> (ø) :arrow_down:
...api/control/aggregator/QuotaRequestAggregator.java 53.27% <53.27%> (ø) 14 <14> (ø) :arrow_down:
... and 6 more

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 3143e1f...c848438. Read the comment docs.

tangiel commented 7 years ago

@mangchiandjjoe are you comfortable reviewing Java code? If so can you aid in reviewing quota management in Java?

inklesspen commented 7 years ago

I will definitely look at it soon. I'm sorry about the delay; I lost this review request. However I am pretty rusty on Java, so keep that in mind.

tangiel commented 7 years ago

@mangchiandjjoe Can you let me know if you plan to review further or if I should submit?

tangiel commented 7 years ago

Discussed offline and am submitting now.