search

cloudendpoints / endpoints-python

A Python framework for building RESTful APIs on Google App Engine
Apache License 2.0
51 stars 17 forks source link

Produce OR'd security requirements, not AND'd. #101

Closed inklesspen closed 7 years ago

inklesspen commented 7 years ago

When a method lists audiences for multiple issuers, we should generate a security requirement which accepts any of the issuers, not one which requires all of them.

Fixes #100.

inklesspen commented 7 years ago

Test failed because of different order of security requirements. Let's see.

codecov-io commented 7 years ago

Codecov Report

Merging #101 into master will increase coverage by 0.02%. The diff coverage is 90%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #101      +/-   ##
==========================================
+ Coverage   84.84%   84.86%   +0.02%     
==========================================
  Files          43       43              
  Lines        5788     5809      +21     
==========================================
+ Hits         4911     4930      +19     
- Misses        877      879       +2
Impacted Files Coverage Δ
endpoints/test/openapi_generator_test.py 87.29% <88.88%> (+0.12%) :arrow_up:
endpoints/openapi_generator.py 92.12% <90.9%> (+0.07%) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update c6bb2fa...9ed3983. Read the comment docs.