Closed mbilski closed 1 year ago
Are there any other scenarios where oauth2c
might wait forever? If yes, then please also add timeouts for them.
Maybe having a common --timeout
parameter to set all timeouts would be nice, in many cases I wouldn't care where exactly the timeout happens and I'd need it more as a way to say "if I don't get a token within 1 minute then abort with an error, no matter why that happened".
@schlomo Everywhere else we already have the HTTP client timeout (by default 60s). I think it makes sense to have two distinct timeout configurations. The http requests are fast, while it might take time for a user to log in via a browser especially if 2FA is used etc. I will rename those to --browser-timeout and --http-timeout to clarify
74 Added
--browser-timeout 5m
flag. Renamed current timeout (default 1m) to --http-timeout