search

cloudera-bikeshed / proposal

9 stars 4 forks source link

Fixed inconsistent use of commas. #4

Open templedf opened 8 years ago

templedf commented 8 years ago

In particular, enforced consistent use of the Oxford comma. I can't support a project that could involve the strippers, Hitler and Stalin.

dimaspivak commented 8 years ago

LGTM.

mpercy commented 8 years ago

This is a pretty poor commit message. Please follow the guidelines at http://chris.beams.io/posts/git-commit/ and add more detail to the body of your commit message for those who will come along after you.

mpercy commented 8 years ago

Also, I would appreciate if you would let my PR go in first because I don't have time to rebase right now.

templedf commented 8 years ago

Aside from line wrapping the body, which clearly is your personal hangup, I don't see where the commit message is an issue. And, no, you can't go first.

mpercy commented 8 years ago

If you would read the article above you would understand what's wrong with the commit message:

  1. The In particular part should go underneath in the body of the commit
  2. You should use an active verb, like "Fix", instead of "Fixes"
templedf commented 8 years ago

I don't see an easy way to edit the commit message. I don't think git PRs is a reasonable way to move forward with this project. I'd like to propose that we move to Gerrit for code reviews.

mpercy commented 8 years ago

I'd be open to trying out Gerrit. Have you considered Phabricator? There's also GitLab, I think they have a code review system. Would you mind exploring all of the available options for code review systems and send a summary to the list? Ideally we would have a demo of each one we could try for this project. Once you do that, we could start a [DISCUSS] thread about it.