Add more test for transparent_hugepage

cloudera-ps / prereq-checks

Prerequisites checker for Cloudera Manager and CDP PVC Base installations

GNU General Public License v3.0

57 stars 58 forks source link

Add more test for transparent_hugepage #136

Closed krishnakalyan3 closed 4 years ago

krishnakalyan3 commented 4 years ago

According to prerequisites in our documentation, we should include

echo never > /sys/kernel/mm/transparent_hugepage/enabled
To make this changes permanent, we should also include changes in /etc/default/grub

Ref: Cloudera Documentation RedHat Knowledge Base Disabling THP

krishnakalyan3 commented 4 years ago

@dbeech can you please review this?.

dbeech commented 4 years ago

Thanks for this @krishnakalyan3. There is an issue because changes need to be made in the scripts under the lib directory. The prereq-check.sh script is created by calling build.sh, which compiles the smaller scripts into one big one.

Please can you re-do your change but make it inside lib/checks.sh instead.

krishnakalyan3 commented 4 years ago

@dbeech thanks for the feedback. Will make the changes.