search

cloudera / cloudera-scripts-for-log4j

Scripts for addressing log4j zero day security issue
Apache License 2.0
86 stars 68 forks source link

missing parameter in find #41

Open sigpet opened 2 years ago

sigpet commented 2 years ago

https://github.com/cloudera/cloudera-scripts-for-log4j/blob/main/cm_cdp_cdh_log4j_jndi_removal.sh#L63 it's missing the -name parameter after -o

line should read for tarfile in $(find -L $targetdir -name ".tar.gz" -o -name ".tgz"); do

I fixed it locally and the find does not error any more

isuller commented 2 years ago

Thank you, fixed.

lhoss commented 2 years ago

It seems fixed by commit https://github.com/cloudera/cloudera-scripts-for-log4j/commit/f27791387d3e767e6688bb649df9994c211221c1 why has the github issue not been closed ?? ( need to keep the list of issues and PRs as clean as possible , it started to get messy )

isuller commented 2 years ago

@lhoss I don't have the right to close an issue - don't know who can. Maybe @sunilgovind knows?