thriftpy 0.3.x TSocket.set_timeout is gone

cloudera / impyla

Python DB API 2.0 client for Impala and Hive (HiveServer2 protocol)

Apache License 2.0

731 stars 248 forks source link

thriftpy 0.3.x TSocket.set_timeout is gone #167

Closed wesm closed 8 years ago

wesm commented 8 years ago

I'm developing primarily with Python 3.x now so I ran into this right away.

laserson commented 8 years ago

Looks like this changed a month ago? https://github.com/eleme/thriftpy/commit/83a921a9b64f26da62704fd5c58fbb3a2a26249f

lxyu commented 8 years ago

add back in https://github.com/eleme/thriftpy/commit/70bfa0b04cb1a551025e1a1902c2fadc85a28705, sorry for the inconvenience.

wesm commented 8 years ago

@lxyu thank you

laserson commented 8 years ago

Moved to the new API in 35ce92af01c06f1c95910a37bd6d1d99f18b9fcd

wesm commented 8 years ago

Are these changes released in thriftpy?

laserson commented 8 years ago

Which changes? The backwards compatibility fix in thriftpy does NOT appear to be in a release. The new API for setting the timeout in thriftpy IS in the latest release, which is why the changes in 35ce92a fixed the build.

wesm commented 8 years ago

gotcha, thanks

avram commented 8 years ago

The changes however are not released in Impyla -- would be great to get a new release of Impyla, preferably one that pins the thriftpy dependency at 0.3.3 to keep this stable.