UnicodeDecodeError with 0.14.2

iamthebot commented 5 years ago

We're seeing major installation failures on Python 3.6 of today's release (0.14.2)

Repro:

pip install impyla on a Python 3.6 conda environment.

Collecting impyla>=0.14.0 (from omniduct[druid,hiveserver2,presto,s3,ssh,webhdfs]<0.8,>=0.7.0->airpy==0.6.5->-r /tmp/python.txt
Downloading impyla-0.14.2.tar.gz (157kB)
Complete output from command python setup.py egg_info:
    Traceback (most recent call last):
      File "<string>", line 1, in <module>
      File "/tmp/pip-build-5g1al_ga/impyla/setup.py", line 34, in <module>
        long_description=readme(),
      File "/tmp/pip-build-5g1al_ga/impyla/setup.py", line 25, in readme
        return ip.read()
      File "/home/default_user/.conda/envs/user/lib/python3.6/encodings/ascii.py", line 26, in decode
        return codecs.ascii_decode(input, self.errors)[0]
UnicodeDecodeError: 'ascii' codec can't decode byte 0xe2 in position 4117: ordinal not in range(128)

dknupp commented 5 years ago

@iamthebot -- I'm thinking the best thing to do is revert the commit, and increment the version number, then do additional testing. I'll try to get the new package uploaded later tonight, or early tomorrow.

dknupp commented 5 years ago

The latest release (0.14.2.2) essentially reverts to 0.14.1, so pip installs should be working again.

If 0.14.2 is already installed, an upgrade will install the new release, which just repackages the previous working commit. This should hopefully unblock installation failures until this unicode issue (and other build problems) can be addressed.

(impyla_test_venv) $ pip list | grep impyla
impyla     0.14.2 
(impyla_test_venv) $ pip install -U impyla
Collecting impyla
Requirement already satisfied, skipping upgrade: six in ./impyla_test_venv/lib/python2.7/site-packages (from impyla) (1.12.0)
Requirement already satisfied, skipping upgrade: bitarray in ./impyla_test_venv/lib/python2.7/site-packages (from impyla) (0.8.3)
Collecting thrift<=0.9.3 (from impyla)
Installing collected packages: thrift, impyla
  Found existing installation: thrift 0.11.0
    Uninstalling thrift-0.11.0:
      Successfully uninstalled thrift-0.11.0
  Found existing installation: impyla 0.14.2
    Uninstalling impyla-0.14.2:
      Successfully uninstalled impyla-0.14.2
Successfully installed impyla-0.14.2.2 thrift-0.9.3

iamthebot commented 5 years ago

Awesome, I'll leave this issue open until the next package releases w/out the unicode install issue. Thanks again for reverting this.

cpcloud commented 5 years ago

@dknupp The issue here is the use of this character in README.md. Is it possible for you to make another release so that libraries that need to support 3.7 are unblocked?

timarmstrong commented 5 years ago

Ah yeah, looks like I copied and pasted those quotes in. I'd just merged a change to remove them, so hopefully that solves the issue.

dknupp commented 5 years ago

@iamthebot -- can you confirm that installing 0.15a1 works in your environment now?

cloudera / impyla

UnicodeDecodeError with 0.14.2 #336