SDK Support for CDH5.10 and above

cloudera / navigator-sdk

Navigator SDK

Apache License 2.0

22 stars 23 forks source link

SDK Support for CDH5.10 and above #79

Closed aadarshjajodia closed 7 years ago

aadarshjajodia commented 7 years ago

@changhiskhan

aadarshjajodia commented 7 years ago

@changhiskhan

changhiskhan commented 7 years ago

Have more review comments. Also, but just wanted to start the conversation early while i'm finishing the review.

aadarshjajodia commented 7 years ago

Hi @changhiskhan, as discussed I have removed the IdAttrs. Now each entity will return an IdAttrsMap which can be set directly to the ep1/ep2 attributes in a Relation. Also i have made the method validateEntity to be non-abstract and removed empty stubs.

changhiskhan commented 7 years ago

Also, do you have a solution for the duplicate relations problem? If not, can you ask Vikas for help?

changhiskhan commented 7 years ago

Just had that one minor comment. Outside of that I think we're probably OK for this change. Important things:

Looks like the unit tests are passing so that's good
Please run all the examples
Make sure there's clear communication about version compatibility (seek feedback from our partners please).

changhiskhan commented 7 years ago

Also please note that we should NOT use the big green "Merge pull request" button as that breaks linear commit history.