search

cloudevents / sdk-csharp

CSharp SDK for CloudEvents
Apache License 2.0
281 stars 82 forks source link

Optimize encoding #287

Open bencyoung-Fignum opened 8 months ago

bencyoung-Fignum commented 8 months ago

This change optimizes the binary mode formatter when UTF8 is chosen, and allows the memory stream implementation to be overridden (e.g. RecyclableMemoryStream)

jskeet commented 8 months ago

Will try to look at this soon, but it may be next week.

bencyoung-Fignum commented 8 months ago

It's no rush, we're just trying to optimize our eventing and this is something I wanted to check

jskeet commented 8 months ago

There are a few things I'd probably want to change here - I wonder if the best thing is for me to create an PR from scratch rather than leave a bunch of nitpicks, then get you to review that new PR. Does that work for you?

bencyoung-Fignum commented 8 months ago

Absolutely, it was just a PoC

jskeet commented 8 months ago

Great. I'll try to come up with something next week.