search

cloudevents / sdk-csharp

CSharp SDK for CloudEvents
Apache License 2.0
281 stars 82 forks source link

#286 Add in a framework reference for net8 #289

Closed thompson-tomo closed 7 months ago

thompson-tomo commented 8 months ago

This adds in the asp net framework reference for the net8 TFM so that packages can be decreased.

Closes #286

jskeet commented 7 months ago

The build is failing, presumably due to some differences in nullability annotations. Are you happy to look into that yourself, or would you like me to do it in a separate commit still within this PR?

thompson-tomo commented 7 months ago

Yeap, I will look through it over the next couple of days.

thompson-tomo commented 7 months ago

Have gone through and fixed the null reference errors and at the same time updated the tests based https://github.com/aspnet/Announcements/issues/377 which was being used in a number of locations.

jskeet commented 7 months ago

Will try to look at this next week. (Today and Monday are UK public holidays.)

thompson-tomo commented 7 months ago

No problem at all. 🙂

thompson-tomo commented 7 months ago

Agree with the 2 proposed changes & I will make them over the weekend.