cloudevents / sdk-csharp

CSharp SDK for CloudEvents
Apache License 2.0
282 stars 82 forks source link

Check case sensitivity uses #90

Closed jskeet closed 3 years ago

jskeet commented 3 years ago

We're fixing the use of CloudEvent attributes themselves not previously being case-sensitive, but every transport has its own rules, and we should check we're doing the right thing. In particular, often we're using an "invariant culture case-insensitive match" instead of an "ordinal case-insensitive match" and I don't know that that will always be the right approach.

jskeet commented 3 years ago

Places using "IgnoreCase":

Of course, it's possible that there are other places that should be case-insensitive but aren't...

jskeet commented 3 years ago

Judging by RecordHeaders.java and Headers.cs, header keys are expected to be case-sensitive. Will fix.