search

cloudevents / sdk-go

Go SDK for CloudEvents
https://cloudevents.github.io/sdk-go/
Apache License 2.0
776 stars 216 forks source link

Sync CESQL tck tests #1010

Closed Cali0707 closed 4 months ago

Cali0707 commented 4 months ago

I recently realized that the tck tests for CESQL are not up to date with the new ones added in the spec repo. This PR just copies those changes over into sdk-go, and registers the new test file.

cc @duglin @pierDipi

duglin commented 4 months ago

hmm @Cali0707 looks like the tests caught some errors in the code

Cali0707 commented 4 months ago

@duglin I think the tests should work now, would you mind enabling the them?

Cali0707 commented 4 months ago

It was a mix of incorrect test cases and one bug in the code, I'll bring the fixes from here back to the spec repo once we merge the code here and have everything passing

duglin commented 4 months ago

thanks! /LGTM ping @lionelvillard @embano1