search

cloudevents / sdk-go

Go SDK for CloudEvents
https://cloudevents.github.io/sdk-go/
Apache License 2.0
776 stars 216 forks source link

#1039 Migrate azure/go-amqp to version 1.0.5 #1040

Open cx-joses opened 1 month ago

cx-joses commented 1 month ago

Changes:

Fixes #1039

embano1 commented 1 month ago

Thx for the quick fix! Question: is the reason to bump to go 1.22 due to the amqp bump or actually not needed?

cx-joses commented 1 month ago

Thx for the quick fix! Question: is the reason to bump to go 1.22 due to the amqp bump or actually not needed?

@embano1 actually it was not supposed to be done. I was thinking of upgrading it all but there is no need and required more changes.

embano1 commented 1 month ago

Thx, I still see the bumps though?

cx-joses commented 1 month ago

Thx, I still see the bumps though?

@embano1 I actually upgraded to 1.21 since its the version referred on build steps and others. do you see any issue in doing so?

embano1 commented 1 month ago

@embano1 I actually upgraded to 1.21 since its the version referred on build steps and others. do you see any issue in doing so?

IMHO we want to keep 1.18 so we don't introduce additional changes/features that might block users compiling with older go versions. The README states:

Note: Supported go version: 1.18+

cx-joses commented 1 month ago

@embano1 I actually upgraded to 1.21 since its the version referred on build steps and others. do you see any issue in doing so?

IMHO we want to keep 1.18 so we don't introduce additional changes/features that might block users compiling with older go versions. The README states:

Note: Supported go version: 1.18+

understood, you are absolutely right! reverted it all to 1.18 again! thanks