Updated example keyword to json_schema_extra

cloudevents / sdk-python

Python SDK for CloudEvents

https://pypi.org/p/cloudevents/

Apache License 2.0

266 stars 53 forks source link

Updated example keyword to json_schema_extra #233

Closed jason-tang5 closed 1 month ago

jason-tang5 commented 5 months ago

Fixes https://github.com/cloudevents/sdk-python/issues/231

Changes

Received the following warning: "PydanticDeprecatedSince20: Using extra keyword arguments on Field is deprecated and will be removed. Use json_schema_extra instead. (Extra keys: 'example')." so we updated the example keyword to json_schema_extra.

One line description for the changelog

Updated example keyword to json_schema_extra

[X] Tests pass
[X] Appropriate changes to README are included in PR

xSAVIKx commented 1 month ago

Hey @jason-tang5, sorry it took me so long to review this.

I believe it should have been implemented using examples keyword instead and was covered by the other PR https://github.com/cloudevents/sdk-python/pull/235. I'm gonna close this one and sorry again for not getting back earlier.