search

cloudflare / Cloudflare-WordPress

A Cloudflare plugin for WordPress
https://www.cloudflare.com/wordpress/
BSD 3-Clause "New" or "Revised" License
208 stars 84 forks source link

SPEED-777: Upgrade cloudflare-plugin-frontend to v3.8.0 (#534) #535

Closed aseure closed 4 months ago

aseure commented 4 months ago

🔖 Summary

By upgrading the compiled files from cloudflare-plugin-frontend as of v3.8.0, this commit aims at removing all Railgun-related code, which is now a deprecated Cloudflare feature. This change is proposed due to a Bad Request banner which is now shown on the Cloudflare Wordpress plugin page because of a failing call to one of the deprecated Railgun endpoints.

Close #534.

aseure commented 4 months ago

@jacobbednarz I've looked at the git history, but couldn't understand how the compiled.js.map is now produced in cloudflare-plugin-frontend. My understanding is that we changed the build tool from gulp to npm and now yarn in cloudflare-plugin-frontend and the gulp compress command is now outdated. If not, could you tell me what's the best way to produce that file. If so, is the compiled.js.map file now outdated and could be removed?

jacobbednarz commented 4 months ago

as far as i recall, we just need to update the version use by the JS package manager and that should be enough (yarn upgrade ... type of thing)

aseure commented 4 months ago

@jacobbednarz Thing is, there's no JS package manager configuration in this repository (i.e. no package.json). All I did in the cloudflare-plugin-frontend was to run yarn build:production and copy-paste the resulting compiled.js file in that repository. However, no compiled.js.map got generated, hence my question.

jacobbednarz commented 4 months ago

works for me! the process i was thinking of is for the backend plugin that i already merged in so disregard that.

if you want to in the future, you can pull the frontend code into this repository and have it build in place to save the confusion.