cloudflare / Cloudflare-WordPress

A Cloudflare plugin for WordPress
https://www.cloudflare.com/wordpress/
BSD 3-Clause "New" or "Revised" License
216 stars 83 forks source link

Allow `psr/log` v3 when using composer #541

Open LeoColomb opened 8 months ago

LeoColomb commented 8 months ago

Alternative solution for #539. This helps to work around the issue regarding the conflicted dependencies (specifically Psr\Log package). This would allow installing the package on a PHP 8 server via Composer, while keeping the wp.org plugin a PHP 7.x target.

[!NOTE] This change requires the plugin to be published as a standard package on Packagist and then be released with a new tag. https://packagist.org/packages/submit

[!Warning] A conditional class definition is unfortunately required to match psr/log methods signatures. This is not very pretty, but, again, required. b6e81b9



cc @Korben00

JulienMelissas commented 6 months ago

Would be great to get this reviewed/approved! We had a few hundred sites go down today updating Cloudflare via Composer thanks to this fun error 😅 (still trying to figure out why the error didn't show itself in staging)

LeoColomb commented 6 months ago

@JulienMelissas If you are a business customer of Cloudflare, don't hesitate to open an internal ticket in their support area. If so, feel free to reference our ticket 3130507.

LeoColomb commented 6 months ago

@aseure @jacobbednarz @william-woodhead Any possible feedback?

tomkyser commented 3 months ago

@aseure @jacobbednarz @william-woodhead any update? I've got a pile of duct tape getting our composer based project to work with this plugin specifically being the issue. What's holding it up?

dev-triboo commented 2 months ago

@aseure @jacobbednarz @william-woodhead any update?