Fix deploy example for vendored dependencies

chinedufn commented 8 years ago

Ran into some trouble using the example circle config with the newly vendored dependencies.

Config change in this PR fixed my builds :)

renandincer commented 8 years ago

@zackbloom

renandincer commented 8 years ago

Have you tried building it without godep? It should work with the vendored in dependencies in Go 1.5+.

post:
    - git clone git@github.com:EagerIO/Stout.git
    - cd Stout; go build -o ../stout src/*.go

chinedufn commented 8 years ago

I haven't. A bit unfamiliar with go so thanks a lot for the example!

I'll give that a try and adjust the PR if it works

chinedufn commented 8 years ago

@renandincer worked perfectly. Updated this PR to use your example steps!

renandincer commented 8 years ago

Great 👍👍 thanks. Included it here https://github.com/EagerIO/Stout/pull/29

chinedufn commented 8 years ago

Hmmm so this no longer works for me.

Seems like the vendored deps directory isn't getting checked.

Looks like circleci uses go 1.5.3 and 1.6.2, so should be good on the v1.5+ side of things.

Did a bit of googling and landed on adding go get in order to fetch the deps.

    - git clone git@github.com:EagerIO/Stout.git
    - go get -t -d -v ./...
    - cd Stout; go build -o ../stout src/*.go

Temporary until I can figure out why the vendor directory isn't working.

Do your builds work?

Cheers and thanks!

Extra context

The build steps in this PR worked for me on July 26, 2016. I haven't built in between then, so the earliest fail time that I know of is August 7, 2016.

Not yet sure what might have changed in between those two dates. Doesn't seem to be an issue in EagerIO/Stout.

zackbloom commented 8 years ago

@chinedufn Which version of Go are you using?

chinedufn commented 8 years ago

@zackbloom on local machine - go1.5beta1 darwin/amd64. No luck there

cloudflare / Stout

Fix deploy example for vendored dependencies #26

Extra context