Closed yoderme closed 2 years ago
Wow, that was easy, thanks for merging!
Hey @nmldiegues I was just also made aware that https://github.com/cloudflare/helm-charts exists, what do you think about putting this over there as well?
Suggestion: open a PR there with a link to the folder in this repo, that way we avoid duplication, and maximize visibility
When you say "a link to the folder in this repo" what do you mean exactly? git submodule?
I have given it another thought and had a change of heart: what about moving these contents to that repo, and then change this repo to still have a folder about a helm example but whose contents point to the other repo to avoid duplication?
The other repo has a legacy approach to using Tunnels in k8s, so I think it would be great to replace it with the approach you are using now with Named Tunnels
@nmldiegues can you have a look at https://github.com/cloudflare/helm-charts/pull/25 ? It hasn't gotten any attention over there... Thanks!
This is in reference to github issue #16. I saw the example yaml in the named-tunnel-k8s directory and thought it would be much more useful as a helm chart. And I had to make a helm chart anyway so I could deploy it with Terraform. Here's the result, and figured I'd contribute it back.
Not sure how you'd like to work this into examples or have it be stand-alone, so here's a start in a stand-alone directory.