Fix nil pointer dereference when monitoring specs for changes

cloudflare / certmgr

Automated certificate management using a CFSSL CA.

BSD 2-Clause "Simplified" License

218 stars 40 forks source link

Fix nil pointer dereference when monitoring specs for changes #100

Closed jmunson closed 4 years ago

jmunson commented 4 years ago

This looks like it was a typo, current behavior is to only add a WakeCallBack if there is an error and if there is an error, s will be a nil pointer, crashing every time.

jmunson commented 4 years ago

Had some issues with working on the wrong branch, and a rebase mishap while working this, so sorry for the noise.

The total changes are still pretty reasonable so I'll just leave this as is

jmunson commented 4 years ago

also noticed CI broke from me trying to upgrade viper and cobra. In hindsight this isn't really needed, so we could just revert back to the old versions, but we should probably also upgrade all deps and re-vendor so we don't fall too far behind. I'll follow up on this tomorrow

edit: cleaning this up now, splitting this into multiple PRs