search

cloudflare / certmgr

Automated certificate management using a CFSSL CA.
BSD 2-Clause "Simplified" License
218 stars 40 forks source link

Drop `certmgr --sync` support. #63

Closed ferringb closed 5 years ago

ferringb commented 5 years ago

To my knowledge, no one knew it was there- and how it was written meant that we had two implementations of the same code.

No usage, and having to maintain duplicate code == remove it.

ferringb commented 5 years ago

One thing: CheckCertsSync() was one of the only functions to use the FailureCount metric. FailureCount is still used in renewCert()... is this still a useful metric or should it be killed too?

I'd keep the metric personally; it should be fairly rare for it to ever fire, but if it does, it really is a signal that should be exposed.