cloudflare / certmgr

Automated certificate management using a CFSSL CA.
BSD 2-Clause "Simplified" License
218 stars 40 forks source link

Refactoring #72

Closed ferringb closed 5 years ago

ferringb commented 5 years ago

Core thrust here: 1) Drop CertServiceManager, move it into Spec. This seperation forced exposing multiple internals that are ill designed/defined; dropping this 'wrapper' allows hiding more internals which allows refactoring and cleanup to happen without breaking API. 2) Via 1, privatize (and rename where sensical) spec methods to hide internals that shouldn't be public. 3) Move more of the parse logic down into File itself via using unmarshall methods; point there is to reduce the requirements of Spec to know to invoke specific methods as part of initialization; instead, just have initialization handle this. 4) Minor error message cleanup; removal of newlines. More work will follow. 5) Add a link to the godocs since we're progressively getting closer to a usable API.