cloudflare / certmgr

Automated certificate management using a CFSSL CA.
BSD 2-Clause "Simplified" License
218 stars 40 forks source link

Reject broken servicemanager definitions in specs #82

Closed ferringb closed 5 years ago

ferringb commented 5 years ago

If a spec explicitly defines action, service, or svcmgr, then the spec is trying to configure a notification mechanism.

This PR changes logic such that it's mandatory that this parse; if it cannot, then the spec is rejected and code above behaves accordingly (fails namely).

If no field is defined, then we treat the spec as 'dummy'- albeit logging a warning that there is no notification mechanism configured.