search

cloudflare / cf-ui

:gem: Cloudflare UI Framework
Other
1.29k stars 81 forks source link

Added package-lock.json to gitignore #246

Closed manatarms closed 7 years ago

manatarms commented 7 years ago

TLDR; This PR ignores the auto generated NPM5 package-lock.json file.

Not that NPM@5 is out, it generates a package-lock.json file by default. But since we're using yarn we don't need the package-lock.json.

If anyone feels strongly about committing the package-lock.json to the repo, I'll open another PR that commits the package-lock.json files.

jwineman commented 7 years ago

How strict do we want to be on this? We don't use NPM on CF-UI and if we did we aren't using NPM5.

Obviously there isn't any harm in merging this but I sort of lean toward declining it since we want people using Yarn.

manatarms commented 7 years ago

@jwineman My bad. My wording was confusing. This PR ignores the package-lock.json file generated by NPM5.

jwineman commented 7 years ago

I know. My point is we want people using yarn, not NPM 5, adding the lock file to gitignore sends a mixed message.

manatarms commented 7 years ago

Ohhh. I see what you mean. The annoying thing is that NPM generates the files whenever it touches node_modules or package.json. I was doing some npm stuff (npm version patch I think) and it decided to make a lock file for all of our packages.