search

cloudflare / cf-ui

:gem: Cloudflare UI Framework
Other
1.29k stars 81 forks source link

Icon sizes are wrong in cf-component-icon #260

Closed thellimist closed 7 years ago

thellimist commented 7 years ago

https://cloudflare.github.io/cf-ui/#cf-component-icon

koddsson commented 7 years ago

I can get this fixed in #199 although I'm trying to push that each implementation should overwrite the font-size property itself for fine-grained size controls.

wyuenho commented 7 years ago

The sizes are not wrong. The icons are not meant to be looked at as an entire set like your regular fonts, so if some glyph seems drastically smaller, that's because you are comparing it to the bigger ones. We could get the designers to give us an entirely new set of icons, but they are probably still not going to look all the same size. Icons only need to look consistent to the surrounding contexts.

koddsson commented 7 years ago

@wyuenho I'm not sure I follow. How are the icons sizes not wrong when they are all the same size?

koddsson commented 7 years ago

This is blocked while #199 is blocked. Will revisit when that one is merged/closed.

toekneestuck commented 7 years ago

Moved internal.