cloudflare / cf-ui

:gem: Cloudflare UI Framework
Other
1.29k stars 81 forks source link

chore(tooling): force conventional commits #269

Closed koddsson closed 7 years ago

koddsson commented 7 years ago

Add the packages husky and validate-commit-msg to create a precommit git hook that rejects commits that do not adhere to the conventional commits standard1.

This enables us to run lerna publish with the flag --conventional-commits which will autogenerate a changelog and set the package versions automatically. This PR enables this flag.

Closes: #237

sejoker commented 7 years ago

@koddsson could you update CONTRIBUTING.md with link to https://conventionalcommits.org/ and small explanation why we decided to go with it.

koddsson commented 7 years ago

@sejoker Sure! I was thinking about also not merging this until next monday so I can walk through what this change would mean for the team?

sejoker commented 7 years ago

@koddsson cool thanks, that would be nice.

koddsson commented 7 years ago

I tried this on a different branch and it works like a charm! Didn't prompt me for the change but determined it from the commit.

image