search

cloudflare / cf-ui

:gem: Cloudflare UI Framework
Other
1.29k stars 81 forks source link

fix(cf-component-form): FormFieldset invalid propTypes #304

Closed jrf0110 closed 7 years ago

jrf0110 commented 7 years ago

I saw that in our example, this component was failing validation since this prop was missing (and it's specified as required). However, it's not really required. The component defaults to vertical. Well, that's not exactly true. All input that isn't horizontal is treated as vertical.

tajo commented 7 years ago

I am fine with removing isRequired but in that case I would add FormFieldset.defaultProps.

jrf0110 commented 7 years ago

but in that case I would add FormFieldset.defaultProps.

Sure. Will do. It doesn't actually make any difference with the way it currently works, but if someone changes the implicit code later on, then having it explicitly default will be good.

koddsson commented 7 years ago

Oh man that was supposed to be an approval! 😞