search

cloudflare / cf-ui

:gem: Cloudflare UI Framework
Other
1.29k stars 81 forks source link

chore(cf-component-box): Added missing display table props #327

Closed manatarms closed 7 years ago

koddsson commented 7 years ago

Not a comment on this PR but rather cf-ui as a whole

It's kind of ridiculous that we need to do stuff like this IMHO.

manatarms commented 7 years ago

@koddsson I totally agree. But I feel this is a side effect of our Fela migration. Once we figure all the props we need, it should stabilize :)

koddsson commented 7 years ago

I'm not sure @manatarms, but I guess time will tell :)

tajo commented 7 years ago

It's kind of ridiculous that we need to do stuff like this IMHO.

You don't really need to do that. You can use createComponent. <Box /> was never meant as a full-featured replacement. It's more an experiment and I think it's fine for extra margin/padding but we definitely don't have to copy&paste the whole CSS spec into it.

koddsson commented 7 years ago

Does it just work like this?

createComponent({ backgroundColor: 'red' }, Box)