search

cloudflare / cf-ui

:gem: Cloudflare UI Framework
Other
1.29k stars 81 forks source link

feat(cf-component-select): update styles #369

Closed marksteyn closed 7 years ago

marksteyn commented 7 years ago

Move all styles to fela.

Prevent page scrolling the scrolling the menu.

sejoker commented 7 years ago

Test are passing, Linting is not.

manatarms commented 7 years ago

Prevent page scrolling the scrolling the menu. OMG thank you.

manatarms commented 7 years ago

Looks good! Thanks for this.

manatarms commented 7 years ago

I didn't see a BREAKING CHANGE in any of the commit messages. We should do a major version bump for this.

marksteyn commented 7 years ago

This is my first time using conventional comments - do we have any documentation in the wiki for it?

manatarms commented 7 years ago

This should help https://conventionalcommits.org/ But I agree with you. We should add some docs about it. And also enforce it on CI :( This is how I do breaking changes https://github.com/cloudflare/cf-ui/pull/367/commits/e954159b60c3656b5e386373303c870b79635850