search

cloudflare / cfrpki

Cloudflare's RPKI Toolbox
https://rpki.cloudflare.com
BSD 3-Clause "New" or "Revised" License
175 stars 44 forks source link

Fixing race condition in MainValidation #107

Closed taktv6 closed 2 years ago

taktv6 commented 2 years ago

Fixing this race condition:

==================
WARNING: DATA RACE
Write at 0x00c000010008 by main goroutine:
  main.(*state).MainValidation()
      /home/takt/git/src/github.com/cloudflare/cfrpki/cmd/octorpki/octorpki.go:812 +0x485
  main.main()
      /home/takt/git/src/github.com/cloudflare/cfrpki/cmd/octorpki/octorpki.go:1374 +0x38f3

Previous read at 0x00c000010008 by goroutine 78:
  main.(*state).MainValidation.func1.1()
      /home/takt/git/src/github.com/cloudflare/cfrpki/cmd/octorpki/octorpki.go:841 +0x84
  github.com/getsentry/sentry-go.(*Hub).WithScope()
      /home/takt/go/pkg/mod/github.com/getsentry/sentry-go@v0.11.0/hub.go:189 +0x95
  github.com/getsentry/sentry-go.WithScope()
      /home/takt/go/pkg/mod/github.com/getsentry/sentry-go@v0.11.0/sentry.go:89 +0x12b
  main.(*state).MainValidation.func1()
      /home/takt/git/src/github.com/cloudflare/cfrpki/cmd/octorpki/octorpki.go:837 +0xce
  main.(*state).MainValidation·dwrap·7()
      /home/takt/git/src/github.com/cloudflare/cfrpki/cmd/octorpki/octorpki.go:847 +0x47

Goroutine 78 (finished) created at:
  main.(*state).MainValidation()
      /home/takt/git/src/github.com/cloudflare/cfrpki/cmd/octorpki/octorpki.go:831 +0xd7b
  main.main()
      /home/takt/git/src/github.com/cloudflare/cfrpki/cmd/octorpki/octorpki.go:1374 +0x38f3
==================