search

cloudflare / cfrpki

Cloudflare's RPKI Toolbox
https://rpki.cloudflare.com
BSD 3-Clause "New" or "Revised" License
177 stars 44 forks source link

Issue #95: Fix invalid manifests #96

Closed Ichabond closed 3 years ago

Ichabond commented 3 years ago

As discovered by @job, the validator was not validating the NextUpdate property of the Manifest files. This caused stale information to be validated. This patch checks if the RPKI Manifest NextUpdate is in the future, and not the past. If it's in the past, we invalidate the Parent of the Manifest.

Ichabond commented 3 years ago

review sniping 2 comments, feel free to ignore ;)

Updated the messages to be clearer.

Ichabond commented 3 years ago

Updated the PR as per the comments. Note I didn't further refactor as requested by @morrowc , as I think that might turn this into a yak shaving exercise.

morrowc commented 3 years ago

seems great to me :) and yea avoiding the shaving is a thing now in plandemic times... :)