cloudflare / cfssl

CFSSL: Cloudflare's PKI and TLS toolkit
https://cfssl.org/
BSD 2-Clause "Simplified" License
8.61k stars 1.1k forks source link

Understanding OSCP nonce support #740

Open gdhgdhgdh opened 7 years ago

gdhgdhgdh commented 7 years ago

When reading about OCSP in general I see that each request / response pair supports the use of a nonce to help guard against replay attacks.

Hence I was surprised to read at https://github.com/cloudflare/cfssl/blob/master/ocsp/responder.go#L227 that We don't intend to support nonces - would you mind describing why this is the case?

rolandshoemaker commented 7 years ago

The golang x/crypto/ocsp library doesn't support the nonce extension and using a request/response nonce prevents offline signing as each response needs to be signed with the individual request nonce in the body which is not performant.

Also since OCSP responses have a built in validity period there are very few scenarios where a replay attack would actually be that bad.