search

cloudflare / cfssl

CFSSL: Cloudflare's PKI and TLS toolkit
https://cfssl.org/
BSD 2-Clause "Simplified" License
8.65k stars 1.1k forks source link

Add environment proxy support for scan command #870

Open viralpoetry opened 6 years ago

viralpoetry commented 6 years ago

Currently cfssl scan command does not honor http_proxy \ https_proxy environment variables.

I think it is possible to replace existing tls.DialWithDialer with the proxyDialer, but I am not that good in go to do it myself.

Example where env vars works:
https://github.com/eclipse/paho.mqtt.golang/commit/1b9640aa57fba9bed9a90ec76fd9e5f32206ee4d#diff-e2893928b1f232947cf45a36fdcb6f9bR88

Thanks!

kisom commented 6 years ago

I don't have the bandwidth to work on this, but I'd be happy to review any PRs.