search

cloudflare / circl

CIRCL: Cloudflare Interoperable Reusable Cryptographic Library
http://blog.cloudflare.com/introducing-circl
Other
1.26k stars 138 forks source link

TestScalarMult/wrong_P is failing with Go 1.18 #329

Closed jawn-smith closed 2 years ago

jawn-smith commented 2 years ago

Per https://go.dev/doc/go1.18: "Operating on invalid curve points (those for which the IsOnCurve method returns false, and which are never returned by Unmarshal or a Curve method operating on a valid point) has always been undefined behavior, can lead to key recovery attacks, and is now unsupported by the new backend."

This change means that TestScalarMult/wrong_P will always fail, and should be removed.

armfazh commented 2 years ago

Have you take a look at #327 I rewrote that test to one that is equivalent.

armfazh commented 2 years ago

@GlenPickle Thanks for raising this issue,

Fixed by #327