search

cloudflare / circl

CIRCL: Cloudflare Interoperable Reusable Cryptographic Library
http://blog.cloudflare.com/introducing-circl
Other
1.23k stars 136 forks source link

Use untyped consts for Kyber params #398

Closed tmthrgd closed 1 year ago

tmthrgd commented 1 year ago

These two constants are unnecessarily typed. This flows through all the way to the kem/kyber/kyberN packages where they cause PrivateKeySize and PublicKeySize to also be unnecessarily typed.

bwesterb commented 1 year ago

@armfazh This change should not break compatibility, but it will break compatibility if we need to reintroduce types on these constants for some reason later on. I don't have strong feelings either way. What do you think?