search

cloudflare / circl

CIRCL: Cloudflare Interoperable Reusable Cryptographic Library
http://blog.cloudflare.com/introducing-circl
Other
1.22k stars 136 forks source link

Add partially blind RSA implementation #445

Closed chris-wood closed 1 year ago

chris-wood commented 1 year ago

See the specification for more information. This is needed to help experiment with a version of Privacy Pass that supports public metadata, described here.

This change removes some of the interfaces that were previously unused, like the generic blindsign.Verifier and BlindSign.Signer interfaces.

cc @Guss123

bwesterb commented 1 year ago

This breaks the old API. In particular, it will break this online example. Do we need to break it?

chris-wood commented 1 year ago

This breaks the old API. In particular, it will break this online example. Do we need to break it?

I suppose not, but I don't think we need to worry about API stability for a library like this.

chris-wood commented 1 year ago

@bwesterb @armfazh most specific changes have been addressed, but we have open the API compatibility question and stuff about naming.

chris-wood commented 1 year ago

Thanks @armfazh -- I enacted all your suggestions except for the one to merge constructors. I think it's better to avoid constructors with boolean flags. For the other comments regarding key generation and whatnot, we could implement that in this change or separately. Do you have a preference?

chris-wood commented 1 year ago

@armfazh thanks again for the suggestions -- I applied them.

chris-wood commented 1 year ago

Thanks for the changes @armfazh!