search

cloudflare / circl

CIRCL: Cloudflare Interoperable Reusable Cryptographic Library
http://blog.cloudflare.com/introducing-circl
Other
1.3k stars 144 forks source link

Add ML-KEM (FIPS 203). #470

Closed bwesterb closed 2 months ago

bwesterb commented 10 months ago

Implementation of ML-KEM (FIPS 203).

We keep Kyber around (for now) as it's currently widely deployed. Code differences between them are minimal anyway.

Changes from IPD:

  1. Add test against ACVP test vectors — which still have to be updated to match FIPS203. are updated
  2. Add domain separation in internal PKE key generation.
  3. Add modulus check on public key.
bwesterb commented 8 months ago

Lots of nits, the only really "wrong" thing is a documentation comment.

Thanks. Addressed.

mvd-ows commented 4 months ago

Any updates on this? Is there something that prevents it from being merged?

Our view is that the "draft" status will probably remain for some time to come. Hopefully we can see this merged before the draft label is removed.

bwesterb commented 4 months ago

Is there something that prevents it from being merged?

ML-KEM is not final and could well have a breaking change compared to the initial public draft which is implemented by this PR.

Our view is that the "draft" status will probably remain for some time to come.

We expect the final version of ML-KEM this year, and that could be as early as this month.

mvd-ows commented 4 months ago

Thank you for those clarifications, and the quick reply.