search

cloudflare / circl

CIRCL: Cloudflare Interoperable Reusable Cryptographic Library
http://blog.cloudflare.com/introducing-circl
Other
1.22k stars 136 forks source link

Align to the `purego` build tag, removing `noasm` build tag #492

Closed mattyclarkson closed 2 months ago

mattyclarkson commented 3 months ago

The purego build tag has been proposed1 as the de-facto tag for pure Go builds. This is a superset of the noasm tag currently used.

This patch aligns the code base to toggle to pure Go implementation when purego is defined.

Verified that all assembly is excluded by doing:

find . -name '*.s' -exec sed -i -e '$athis-is-not-valid-assembly 12345' {} \;
go test --tags purego ./...

Closes #491

mattyclarkson commented 3 months ago

RFC: @armfazh from discussion on #491

mattyclarkson commented 2 months ago

@armfazh would it be possible to get approval to run the CI on this PR? Thanks.

armfazh commented 2 months ago

Thanks @mattyclarkson for reporting.

mattyclarkson commented 2 months ago

@armfazh would it be possible to get this in a 1.3.8 release? No pressure, we can patch locally. If there are other things in flight on mainline before the next release, happy to wait.