ACVP test "sigVer" is not used in #480

cloudflare / circl

CIRCL: Cloudflare Interoperable Reusable Cryptographic Library

http://blog.cloudflare.com/introducing-circl

Other

1.3k stars 144 forks source link

ACVP test "sigVer" is not used in #480 #516

Closed UladzimirTrehubenka closed 4 weeks ago

UladzimirTrehubenka commented 1 month ago

Observed after merge #480: https://github.com/cloudflare/circl/blob/main/sign/mldsa/mldsa87/acvp_test.go#L48 has "keyGen" and "sigGen" but not "sigVer" (implemented already). However "sigVer" after enable won't work because need to implement a function similar to unsafeSignInternal() like unsafeVerifyInternal(), because exported Verify() uses ctx (empty), but two bytes with zero values are added before verified message anyway.

bwesterb commented 4 weeks ago

Whoops! Thanks for reporting. @armfazh solved it.