search

cloudflare / cloudflare-access-for-atlassian

Authenticate Atlasssian products when using Cloudflare Access
Other
46 stars 15 forks source link

Support for allowing multiple email domains in the Atlassian software Cloudflare Access plugin #70

Open Kollator opened 3 years ago

Kollator commented 3 years ago

As of now, unless I'm missing something, the Cloudflare plugin that is installed to the Atlassian software does not allow multiple email domains as as allowed Cloudflare Access domains . Also, it does not seem to support usage of wildcards.

Do correct me if I am missing something or just generally an idiot.

felipebn commented 3 years ago

Hi @Kollator , you are correct you currently can only setup one email domain and wildcards are not currently supported.

Could you please expand the use case?

Just to note that the domain configuration is optional on the plugin side, so if all domains are allowed on Cloudflare Access you don't need to add any as all domains authenticated by Cloudflare Access will not require the Atlassian login.

Kollator commented 3 years ago

Hi @Kollator , you are correct you currently can only setup one email domain and wildcards are not currently supported.

Could you please expand the use case?

Just to note that the domain configuration is optional on the plugin side, so if all domains are allowed on Cloudflare Access you don't need to add any as all domains authenticated by Cloudflare Access will not require the Atlassian login.

Yo @felipebn, I had a hunch this must've been the case and as mentioned I was rather a general idiot of a user, as yes the plugin already handles the allowed email domains as per configured via Cloudflare Access. So in the case of my original issue the configuration done on the plugin side was but redundant and, honestly unnecessary, which led in using multiple domains not all work as per expected.

However, as this works like so I reckon the original request does not need any "fixing" or "additions", but rather the enhancement of the said allowed email domain field, lest someone would actually have a use case that'd need multiple domain configuration on Atlassian plugin's side?

felipebn commented 3 years ago

Yo @felipebn, I had a hunch this must've been the case and as mentioned I was rather a general idiot of a user, as yes the plugin already handles the allowed email domains as per configured via Cloudflare Access. So in the case of my original issue the configuration done on the plugin side was but redundant and, honestly unnecessary, which led in using multiple domains not all work as per expected.

😅 The configuration currently serves the use case where only one domain (e.g. the company domain) should be allowed and others should authenticate again through Atlassian login.

However, as this works like so I reckon the original request does not need any "fixing" or "additions", but rather the enhancement of the said allowed email domain field, lest someone would actually have a use case that'd need multiple domain configuration on Atlassian plugin's side?

Yes, I think makes sense to have support for multiple domains, I will raise it with the product team 👍 .

Kollator commented 3 years ago

Yes, I think makes sense to have support for multiple domains, I will raise it with the product team .

Aye-o, roger dodger. Thank you for considering this point to be taken into further development as an enhancement. Much obliged.

Also, thank you for helping in solving the initial problemo. Cheers +1